linux-kernel - RE: [PATCH 12/20] x86, edac: use Intel family name macros for edac driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 2 Jun 2016 16:16:24 +0000
From:	"Luck, Tony" <tony.luck@...el.com>
To:	Dave Hansen <dave@...1.net>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:	"x86@...nel.org" <x86@...nel.org>,
	"dave.hansen@...ux.intel.com" <dave.hansen@...ux.intel.com>,
	"mchehab@....samsung.com" <mchehab@....samsung.com>,
	"dougthompson@...ssion.com" <dougthompson@...ssion.com>,
	"bp@...en8.de" <bp@...en8.de>,
	"linux-edac@...r.kernel.org" <linux-edac@...r.kernel.org>
Subject: RE: [PATCH 12/20] x86, edac: use Intel family name macros for edac
 driver

>  Another straightforward replacement of magic numbers.

It would be if I hadn't forgotten that INTEL_FAM6_MODEL_BROADWELL_XEON_D had
a separate model number from the other Broadwell Xeons when I switched the driver
from PCI device lookup to cpu model number.

This needs to add an entry for BDX-DE (use the same table initializer). Probably as
a separate patch before/after this.

-Tony

[The name INTEL_FAM6_MODEL_BROADWELL_XEON_D is so long it will spoil the
line-up of this code ... +1 vote on Boris' suggestion to drop the "MODEL_" bit from all these
names]