linux-kernel - Re: [PATCH] char: Prefer pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160604163640.GA6559@kroah.com>
Date:	Sat, 4 Jun 2016 09:36:40 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Jyoti Singh <jssengar92@...il.com>
Cc:	arnd@...db.de, linux-kernel@...r.kernel.org,
	Jyoti Singh <jssengar@...il.com>
Subject: Re: [PATCH] char: Prefer pr_* instead of printk

On Sat, Jun 04, 2016 at 08:15:11PM +0530, Jyoti Singh wrote:
> This patch replaces all the printk[KERN_INFO] with pr_* in the file
> "ttyprintk.c" addressing the following warning:
> 
> WARNING:Prefer [subsystem eg: netdev]_info([subsystem]dev, ...
> then dev_info(dev,... then pr_info(...  to printk(KERN_INFO ...
> Found with checkpatch

Sometimes checkpatch tells you to do things that are incorrect :)

Are you _sure_ the code works the same before and after this?  The
ttyprintk driver is a bit "special".

Did you test these changes?

thanks,

greg k-h