[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 6 Jun 2016 12:16:47 +0200
From: Pavel Machek <pavel@....cz>
To: Paul Gortmaker <paul.gortmaker@...driver.com>
Cc: linux-kernel@...r.kernel.org,
"Rafael J. Wysocki" <rjw@...ysocki.net>,
Len Brown <len.brown@...el.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Vinod Koul <vinod.koul@...el.com>,
Jon Hunter <jonathanh@...dia.com>, linux-pm@...r.kernel.org
Subject: Re: [PATCH] PM / clk: export symbols for existing pm_clk_<...> API
fcns
On Sun 2016-06-05 13:58:15, Paul Gortmaker wrote:
> While trying to convert a DMA driver from bool to tristate, we
> encountered the following:
>
> ERROR: "pm_clk_add_clk" [drivers/dma/tegra210-adma.ko] undefined!
> ERROR: "pm_clk_create" [drivers/dma/tegra210-adma.ko] undefined!
> ERROR: "pm_clk_destroy" [drivers/dma/tegra210-adma.ko] undefined!
> ERROR: "pm_clk_suspend" [drivers/dma/tegra210-adma.ko] undefined!
> ERROR: "pm_clk_resume" [drivers/dma/tegra210-adma.ko] undefined!
>
> Since in principle there is nothing preventing these functions
> from being used in modular code as well as builtin, we add the
> export of them. We expand the scope to also include:
>
> pm_clk_add
> of_pm_clk_add_clks
> pm_clk_remove
> pm_clk_remove_clk
> pm_clk_init
> pm_clk_runtime_suspend
> pm_clk_runtime_resume
> pm_clk_add_notifier
>
> ...since these functions are also non-static and presumably form
> part of the existing API used by other drivers that may become
> modular in the future.
>
> Cc: "Rafael J. Wysocki" <rjw@...ysocki.net>
Acked-by: Pavel Machek <pavel@....cz>
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Powered by blists - more mailing lists