linux-kernel - Re: [PATCH] PM / clk: export symbols for existing pm_clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3160821.3V0eYIUger@vostro.rjw.lan>
Date:	Thu, 16 Jun 2016 16:04:16 +0200
From:	"Rafael J. Wysocki" <rjw@...ysocki.net>
To:	Pavel Machek <pavel@....cz>,
	Paul Gortmaker <paul.gortmaker@...driver.com>
Cc:	linux-kernel@...r.kernel.org, Len Brown <len.brown@...el.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Vinod Koul <vinod.koul@...el.com>,
	Jon Hunter <jonathanh@...dia.com>, linux-pm@...r.kernel.org
Subject: Re: [PATCH] PM / clk: export symbols for existing pm_clk_<...> API fcns

On Monday, June 06, 2016 12:16:47 PM Pavel Machek wrote:
> On Sun 2016-06-05 13:58:15, Paul Gortmaker wrote:
> > While trying to convert a DMA driver from bool to tristate, we
> > encountered the following:
> > 
> > ERROR: "pm_clk_add_clk" [drivers/dma/tegra210-adma.ko] undefined!
> > ERROR: "pm_clk_create" [drivers/dma/tegra210-adma.ko] undefined!
> > ERROR: "pm_clk_destroy" [drivers/dma/tegra210-adma.ko] undefined!
> > ERROR: "pm_clk_suspend" [drivers/dma/tegra210-adma.ko] undefined!
> > ERROR: "pm_clk_resume" [drivers/dma/tegra210-adma.ko] undefined!
> > 
> > Since in principle there is nothing preventing these functions
> > from being used in modular code as well as builtin, we add the
> > export of them.  We expand the scope to also include:
> > 
> >    pm_clk_add
> >    of_pm_clk_add_clks
> >    pm_clk_remove
> >    pm_clk_remove_clk
> >    pm_clk_init
> >    pm_clk_runtime_suspend
> >    pm_clk_runtime_resume
> >    pm_clk_add_notifier
> > 
> > ...since these functions are also non-static and presumably form
> > part of the existing API used by other drivers that may become
> > modular in the future.
> > 
> > Cc: "Rafael J. Wysocki" <rjw@...ysocki.net>
> 
> Acked-by: Pavel Machek <pavel@....cz>

Applied, thanks!