linux-kernel - Re: linux-4.7-rc2/drivers/rtc/rtc-ds1685.c: 2 * bad if test ?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 7 Jun 2016 18:12:04 -0400
From:	Joshua Kinard <kumba@...too.org>
To:	Alexandre Belloni <alexandre.belloni@...e-electrons.com>,
	David Binderman <linuxdev.baldrick@...il.com>
Cc:	a.zummo@...ertech.it, rtc-linux@...glegroups.com,
	linux-kernel@...r.kernel.org, dcb314@...mail.com
Subject: Re: linux-4.7-rc2/drivers/rtc/rtc-ds1685.c: 2 * bad if test ?

On 06/07/2016 11:30, Alexandre Belloni wrote:
> Hi,
> 
> On 07/06/2016 at 16:18:31 +0100, David Binderman wrote :
>> Hello there,
>>

[snip]

>> Duplicate. Also in the same file:
>>
>> [drivers/rtc/rtc-ds1685.c:265]: (style) Variable 'ctrlb' is assigned a
>> value that is never used.

This looks like it can be removed.  I believe it's a relic of before I added
the handling of either BCD or Binary modes for the SGI Octane's RTC interface.

>> [drivers/rtc/rtc-ds1685.c:812]: (style) Variable 'ctrlc' is assigned a
>> value that is never used.

This needs to be wrapped in #ifdef CONFIG_RTC_DS1685_PROC_REGS, as the value of
'ctrlc' is displayed in /proc/drivers/rtc if that kconfig option is selected on
supported systems.

-- 
Joshua Kinard
Gentoo/MIPS
kumba@...too.org
6144R/F5C6C943 2015-04-27
177C 1972 1FB8 F254 BAD0 3E72 5C63 F4E3 F5C6 C943

"The past tempts us, the present confuses us, the future frightens us.  And our
lives slip away, moment by moment, lost in that vast, terrible in-between."

--Emperor Turhan, Centauri Republic