| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 7 Jun 2016 17:30:27 +0200 From: Alexandre Belloni <alexandre.belloni@...e-electrons.com> To: David Binderman <linuxdev.baldrick@...il.com> Cc: kumba@...too.org, a.zummo@...ertech.it, rtc-linux@...glegroups.com, linux-kernel@...r.kernel.org, dcb314@...mail.com Subject: Re: linux-4.7-rc2/drivers/rtc/rtc-ds1685.c: 2 * bad if test ? Hi, On 07/06/2016 at 16:18:31 +0100, David Binderman wrote : > Hello there, > > 1. > > linux-4.7-rc2/drivers/rtc/rtc-ds1685.c:392]: (style) Redundant > condition: If '!(mday >= 1)', the comparison 'mday <= 31' is always > true. > > Source code is > > if (!(mday >= 1) && (mday <= 31)) > > Maybe better code > > if (!((mday >= 1) && (mday <= 31))) > > 2. > > linux-4.7-rc2/drivers/rtc/rtc-ds1685.c:464]: (style) Redundant > condition: If '!(mday >= 1)', the comparison 'mday <= 31' is always > true. > See http://git.kernel.org/cgit/linux/kernel/git/abelloni/linux.git/commit/?h=rtc-next&id=c5776dec8f2a90a0aa9e197c2900f68fda8dd978 This should fix that issue. > Duplicate. Also in the same file: > > [drivers/rtc/rtc-ds1685.c:265]: (style) Variable 'ctrlb' is assigned a > value that is never used. > [drivers/rtc/rtc-ds1685.c:812]: (style) Variable 'ctrlc' is assigned a > value that is never used. > Well, feel free to send a patch. Please include the name of the tool you used to find that as I pretty much prefer changes that are tested over cleanup form static analysis tools. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com
Powered by blists - more mailing lists