linux-kernel - linux-4.7-rc2/drivers/rtc/rtc-ds1685.c: 2 * bad if test ?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMzoamZ64+P0Np6WQj-8JYhCw+zXdG-VQ7g2-q80fSS2cq+xyQ@mail.gmail.com>
Date:	Tue, 7 Jun 2016 16:18:31 +0100
From:	David Binderman <linuxdev.baldrick@...il.com>
To:	kumba@...too.org, a.zummo@...ertech.it,
	alexandre.belloni@...e-electrons.com, rtc-linux@...glegroups.com,
	linux-kernel@...r.kernel.org, dcb314@...mail.com
Subject: linux-4.7-rc2/drivers/rtc/rtc-ds1685.c: 2 * bad if test ?

Hello there,

1.

linux-4.7-rc2/drivers/rtc/rtc-ds1685.c:392]: (style) Redundant
condition: If '!(mday >= 1)', the comparison 'mday <= 31' is always
true.

Source code is

   if (!(mday >= 1) && (mday <= 31))

Maybe better code

   if (!((mday >= 1) && (mday <= 31)))

2.

linux-4.7-rc2/drivers/rtc/rtc-ds1685.c:464]: (style) Redundant
condition: If '!(mday >= 1)', the comparison 'mday <= 31' is always
true.

Duplicate. Also in the same file:

[drivers/rtc/rtc-ds1685.c:265]: (style) Variable 'ctrlb' is assigned a
value that is never used.
[drivers/rtc/rtc-ds1685.c:812]: (style) Variable 'ctrlc' is assigned a
value that is never used.

Regards

David Binderman