linux-kernel - Re: [alsa-devel] [PATCH v2 5/9] ASoC: mediatek: add structure define and clock control for 2701

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160607161508.GC7510@sirena.org.uk>
Date:	Tue, 7 Jun 2016 17:15:08 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Garlic Tseng <garlic.tseng@...iatek.com>
Cc:	tiwai@...e.de, srv_heupstream@...iatek.com,
	linux-mediatek@...ts.infradead.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	alsa-devel@...a-project.org, koro.chen@...iatek.com,
	PC.Liao@...iatek.com, ir.lian@...iatek.com
Subject: Re: [alsa-devel] [PATCH v2 5/9] ASoC: mediatek: add structure define
 and clock control for 2701

On Fri, Jun 03, 2016 at 12:56:20PM +0800, Garlic Tseng wrote:

> +void mt2701_init_clock(struct mtk_base_afe *afe)
> +{
> +	struct mt2701_afe_private *afe_priv = afe->platform_priv;
> +	int i = 0;
> +
> +	for (i = 0; i < MT2701_CLOCK_NUM; i++) {
> +		afe_priv->clocks[i] = devm_clk_get(afe->dev, aud_clks[i]);
> +		if (IS_ERR(aud_clks[i]))
> +			dev_warn(afe->dev, "%s devm_clk_get %s fail\n",
> +				 __func__, aud_clks[i]);
> +	}
> +}

This looks like we just ignore the error but I'm not seeing anything
that stops us trying to use the clocks or handle deferred probe?

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)