linux-kernel - Re: [alsa-devel] [PATCH v2 6/9] ASoC: mediatek: add mt2701 platform driver implementation.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 7 Jun 2016 17:31:12 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Garlic Tseng <garlic.tseng@...iatek.com>
Cc:	tiwai@...e.de, srv_heupstream@...iatek.com,
	linux-mediatek@...ts.infradead.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	alsa-devel@...a-project.org, koro.chen@...iatek.com,
	PC.Liao@...iatek.com, ir.lian@...iatek.com
Subject: Re: [alsa-devel] [PATCH v2 6/9] ASoC: mediatek: add mt2701 platform
 driver implementation.

On Fri, Jun 03, 2016 at 12:56:21PM +0800, Garlic Tseng wrote:

> +	if (val < 0 || val > MT2701_I2S_NUM) {
> +		dev_err(afe->dev, "%s, num not available, num %d, val %d\n",
> +			__func__, num, val);
> +		return -1;

Real error codes please.

> +static const struct snd_kcontrol_new mt2701_afe_multi_ch_out_asrc3[] = {
> +	SOC_DAPM_SINGLE_AUTODISABLE("Multi ch asrc out3", PWR2_TOP_CON, 7, 1,
> +				    1),
> +};

On/off controls should end in Switch.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)