linux-kernel - Re: [RFC] IB/srp: Remove create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f3d26daf-1805-7046-f45b-b8965156d83f@sandisk.com>
Date:	Tue, 7 Jun 2016 11:32:42 -0700
From:	Bart Van Assche <bart.vanassche@...disk.com>
To:	Bhaktipriya Shridhar <bhaktipriya96@...il.com>,
	Bart Van Assche <bart.vanassche@...disk.com>,
	Doug Ledford <dledford@...hat.com>,
	Sean Hefty <sean.hefty@...el.com>,
	Hal Rosenstock <hal.rosenstock@...il.com>
CC:	Tejun Heo <tj@...nel.org>, <linux-rdma@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [RFC] IB/srp: Remove create_workqueue

On 06/07/2016 11:16 AM, Bhaktipriya Shridhar wrote:
> alloc_workqueue replaces deprecated create_workqueue().
>
> A dedicated workqueue has been used since the workqueue srp_remove_wq with
> workitem &target->remove_work, is a work queue for the SRP target removal.
> WQ_MEM_RECLAIM has been set to ensure forward progress under memory
> pressure.
> Since there are only a fixed number of work items, explicit
> concurrency limit is unnecessary here.
>
> Is the workqueue being used on a memory reclaim path?
> Does it require WQ_MEM_RECLAIM?

Hello Bhaktipriya,

srp_remove_wq is used for SRP target port removal work only. This work 
is neither queued from inside a shrinker nor by the page writeback code 
so I think it is safe to drop WQ_MEM_RECLAIM.

Thanks,

Bart.