linux-kernel - Re: [PATCH] rtl8xxxu: fix typo on variable name, compare against correct variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <wrfjr3c8yddq.fsf@redhat.com>
Date:	Tue, 07 Jun 2016 16:04:17 -0400
From:	Jes Sorensen <Jes.Sorensen@...hat.com>
To:	Colin King <colin.king@...onical.com>
Cc:	Kalle Valo <kvalo@...eaurora.org>, linux-wireless@...r.kernel.org,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rtl8xxxu: fix typo on variable name, compare against correct variable

Jes Sorensen <Jes.Sorensen@...hat.com> writes:
> Colin King <colin.king@...onical.com> writes:
>> From: Colin Ian King <colin.king@...onical.com>
>>
>> path_b_ok is being assigned but immediately after path_a_ok is being
>> compared to the value 0x03.  This appears to be a typo on the
>> variable name, compare path_b_ok instead.
>>
>> Signed-off-by: Colin Ian King <colin.king@...onical.com>
>> ---
>>  drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8192e.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8192e.c b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8192e.c
>> index fe19ace..b04cf30 100644
>> --- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8192e.c
>> +++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_8192e.c
>> @@ -1149,7 +1149,7 @@ static void rtl8192eu_phy_iqcalibrate(struct rtl8xxxu_priv *priv,
>>  
>>  		for (i = 0; i < retry; i++) {
>>  			path_b_ok = rtl8192eu_rx_iqk_path_b(priv);
>> -			if (path_a_ok == 0x03) {
>> +			if (path_b_ok == 0x03) {
>>  				val32 = rtl8xxxu_read32(priv,
>>  							REG_RX_POWER_BEFORE_IQK_B_2);
>>  				result[t][6] = (val32 >> 16) & 0x3ff;
>
> Nice catch, that does indeed look like a bug!
>
> Thanks, I want to test it, but I plan to apply it to rtl8xxxu-devel
> shortly.

Tested and applied!

Thanks,
Jes