linux-kernel - Re: [PATCH 04/10] x86, asm: define CC_SET() and CC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1be57ead-ac87-1ccb-c7f1-07d54e6f8c6e@zytor.com>
Date:	Wed, 8 Jun 2016 12:29:28 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Andy Lutomirski <luto@...capital.net>,
	"H. Peter Anvin" <hpa@...ux.intel.com>
Cc:	Ingo Molnar <mingo@...nel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Borislav Petkov <bp@...en8.de>
Subject: Re: [PATCH 04/10] x86, asm: define CC_SET() and CC_OUT() macros

On 06/07/16 22:09, Andy Lutomirski wrote:
> On Tue, Jun 7, 2016 at 4:31 PM, H. Peter Anvin <hpa@...ux.intel.com> wrote:
>> From: "H. Peter Anvin" <hpa@...or.com>
>>
>> The CC_SET() and CC_OUT() macros can be used together to take
>> advantage of the new __GCC_ASM_FLAG_OUTPUTS__ feature in gcc 6+ while
>> remaining backwards compatible.  CC_SET() generates a SET instruction
>> on older compilers; CC_OUT() makes sure the output is received in the
>> correct variable.
> 
> Nice.
> 
> Reviewed-by: Andy Lutomirski <luto@...nel.org>
> 

Did you mean this for the entire patch series or for this one patch
only?  I want to make sure to add the proper tags for the repost.

	-hpa