linux-kernel - Re: [PATCH] LSM: module hierarchy in /proc/.../attr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201606090609.TTPZsO9T%fengguang.wu@intel.com>
Date:	Thu, 9 Jun 2016 06:56:20 +0800
From:	kbuild test robot <lkp@...el.com>
To:	Casey Schaufler <casey@...aufler-ca.com>
Cc:	kbuild-all@...org, LSM <linux-security-module@...r.kernel.org>,
	James Morris <jmorris@...ei.org>,
	John Johansen <john.johansen@...onical.com>,
	Stephen Smalley <sds@...ho.nsa.gov>,
	Paul Moore <paul@...l-moore.com>,
	Tetsuo Handa <penguin-kernel@...ove.sakura.ne.jp>,
	Kees Cook <keescook@...omium.org>,
	LKLM <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] LSM: module hierarchy in /proc/.../attr

Hi,

[auto build test WARNING on security/next]
[also build test WARNING on v4.7-rc2 next-20160608]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Casey-Schaufler/LSM-module-hierarchy-in-proc-attr/20160609-055140
base:   https://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security.git next
reproduce: make htmldocs

All warnings (new ones prefixed by >>):

   lib/crc32.c:148: warning: No description found for parameter 'tab)[256]'
   lib/crc32.c:148: warning: Excess function parameter 'tab' description in 'crc32_le_generic'
   lib/crc32.c:293: warning: No description found for parameter 'tab)[256]'
   lib/crc32.c:293: warning: Excess function parameter 'tab' description in 'crc32_be_generic'
   lib/crc32.c:1: warning: no structured comments found
   mm/memory.c:2881: warning: No description found for parameter 'old'
>> security/security.c:127: warning: No description found for parameter 'hooks'
>> security/security.c:127: warning: No description found for parameter 'count'
>> security/security.c:127: warning: No description found for parameter 'lsm'

vim +/hooks +127 security/security.c

   111	 * Otherwise, return false.
   112	 */
   113	int __init security_module_enable(const char *module)
   114	{
   115		return !strcmp(module, chosen_lsm);
   116	}
   117	
   118	/**
   119	 * security_add_hooks - Add a modules hooks to the hook lists.
   120	 * @hooks - the hooks to add
   121	 * @count - the number of hooks to add
   122	 *
   123	 * Each LSM has to register its hooks with the infrastructure.
   124	 */
   125	void __init security_add_hooks(struct security_hook_list *hooks, int count,
   126					char *lsm)
 > 127	{
   128		int i;
   129	
   130		for (i = 0; i < count; i++) {
   131			hooks[i].lsm = lsm;
   132			list_add_tail_rcu(&hooks[i].list, hooks[i].head);
   133		}
   134		if (lsm_append(lsm, &lsm_names) < 0)
   135			panic("%s - Cannot get early memory.\n", __func__);

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (6370 bytes)