linux-kernel - Re: [PATCH] LSM: module hierarchy in /proc/.../attr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201606090641.IDXIrFq9%fengguang.wu@intel.com>
Date:	Thu, 9 Jun 2016 06:49:44 +0800
From:	kbuild test robot <lkp@...el.com>
To:	Casey Schaufler <casey@...aufler-ca.com>
Cc:	kbuild-all@...org, LSM <linux-security-module@...r.kernel.org>,
	James Morris <jmorris@...ei.org>,
	John Johansen <john.johansen@...onical.com>,
	Stephen Smalley <sds@...ho.nsa.gov>,
	Paul Moore <paul@...l-moore.com>,
	Tetsuo Handa <penguin-kernel@...ove.sakura.ne.jp>,
	Kees Cook <keescook@...omium.org>,
	LKLM <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] LSM: module hierarchy in /proc/.../attr

Hi,

[auto build test ERROR on security/next]
[also build test ERROR on v4.7-rc2 next-20160608]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Casey-Schaufler/LSM-module-hierarchy-in-proc-attr/20160609-055140
base:   https://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security.git next
config: x86_64-allmodconfig (attached as .config)
compiler: gcc-6 (Debian 6.1.1-1) 6.1.1 20160430
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

   security/loadpin/loadpin.c: In function 'loadpin_add_hooks':
>> security/loadpin/loadpin.c:185:2: error: too few arguments to function 'security_add_hooks'
     security_add_hooks(loadpin_hooks, ARRAY_SIZE(loadpin_hooks));
     ^~~~~~~~~~~~~~~~~~
   In file included from security/loadpin/loadpin.c:23:0:
   include/linux/lsm_hooks.h:1860:13: note: declared here
    extern void security_add_hooks(struct security_hook_list *hooks, int count,
                ^~~~~~~~~~~~~~~~~~

vim +/security_add_hooks +185 security/loadpin/loadpin.c

9b091556 Kees Cook 2016-04-20  179  	LSM_HOOK_INIT(kernel_read_file, loadpin_read_file),
9b091556 Kees Cook 2016-04-20  180  };
9b091556 Kees Cook 2016-04-20  181  
9b091556 Kees Cook 2016-04-20  182  void __init loadpin_add_hooks(void)
9b091556 Kees Cook 2016-04-20  183  {
9b091556 Kees Cook 2016-04-20  184  	pr_info("ready to pin (currently %sabled)", enabled ? "en" : "dis");
9b091556 Kees Cook 2016-04-20 @185  	security_add_hooks(loadpin_hooks, ARRAY_SIZE(loadpin_hooks));
9b091556 Kees Cook 2016-04-20  186  }
9b091556 Kees Cook 2016-04-20  187  
9b091556 Kees Cook 2016-04-20  188  /* Should not be mutable after boot, so not listed in sysfs (perm == 0). */

:::::: The code at line 185 was first introduced by commit
:::::: 9b091556a073a9f5f93e2ad23d118f45c4796a84 LSM: LoadPin for kernel file loading restrictions

:::::: TO: Kees Cook <keescook@...omium.org>
:::::: CC: James Morris <james.l.morris@...cle.com>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (54751 bytes)