linux-kernel - Re: [PATCH] Add .set_antenna callback in ath6kl driver to remove wireless core warns

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87wplzkbd9.fsf@kamboji.qca.qualcomm.com>
Date:	Wed, 8 Jun 2016 14:23:47 +0000
From:	"Valo, Kalle" <kvalo@....qualcomm.com>
To:	Prasun Maiti <prasunmaiti87@...il.com>
CC:	Linux Kernel <linux-kernel@...r.kernel.org>,
	"ath6kl@...ts.infradead.org" <ath6kl@...ts.infradead.org>,
	Linux Next <linux-next@...r.kernel.org>,
	"Linux Wireless" <linux-wireless@...r.kernel.org>,
	Linux Kernel <prasunmaii87@...il.com>
Subject: Re: [PATCH] Add .set_antenna callback in ath6kl driver to remove
 wireless core warns

Prasun Maiti <prasunmaiti87@...il.com> writes:

> Since add more warnings for inconsistent ops in cfg80211, the wireless
> core warns if a driver implements a cfg80211 callback but doesn't
> implements the inverse operation. The ath6kl driver implements a cfg80211
> .get_antenna operation handler but doesn't have the inverse .set_antenna
> callback. So, it makes warning.
>
> To remove this warning, add .set_antenna callback in ath6kl driver and
> also send a cmd to firmware with it's values.
>
> Signed-off-by: Prasun Maiti <prasunmaiti87@...il.com>

Did you test this? What hardware and firmware version?

-- 
Kalle Valo