linux-kernel - Re: [PATCH] Add .set_antenna callback in ath6kl driver to remove wireless core warns

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEO8o4=DnEfXQAnAOxugC9TngbhvgV9DXz0HOVHNLk0B2fAXQA@mail.gmail.com>
Date:	Wed, 8 Jun 2016 20:05:15 +0530
From:	Prasun Maiti <prasunmaiti87@...il.com>
To:	"Valo, Kalle" <kvalo@....qualcomm.com>
Cc:	Linux Kernel <linux-kernel@...r.kernel.org>,
	"ath6kl@...ts.infradead.org" <ath6kl@...ts.infradead.org>,
	Linux Next <linux-next@...r.kernel.org>,
	Linux Wireless <linux-wireless@...r.kernel.org>,
	Linux Kernel <prasunmaii87@...il.com>
Subject: Re: [PATCH] Add .set_antenna callback in ath6kl driver to remove
 wireless core warns

No. I did not any test for that case.
This driver create a new wiphy for use with cfg80211 through
"wiphy_new_nm" api, but in this api, I found that more warnings for
inconsistent ops are added there. e.g; "WARN_ON(ops->set_antenna &&
!ops->get_antenna);"
So, warning comes during creation of a new wiphy. That's why It is needed.

On Wed, Jun 8, 2016 at 7:53 PM, Valo, Kalle <kvalo@....qualcomm.com> wrote:
> Prasun Maiti <prasunmaiti87@...il.com> writes:
>
>> Since add more warnings for inconsistent ops in cfg80211, the wireless
>> core warns if a driver implements a cfg80211 callback but doesn't
>> implements the inverse operation. The ath6kl driver implements a cfg80211
>> .get_antenna operation handler but doesn't have the inverse .set_antenna
>> callback. So, it makes warning.
>>
>> To remove this warning, add .set_antenna callback in ath6kl driver and
>> also send a cmd to firmware with it's values.
>>
>> Signed-off-by: Prasun Maiti <prasunmaiti87@...il.com>
>
> Did you test this? What hardware and firmware version?
>
> --
> Kalle Valo



-- 
Thanks,
Prasun