linux-kernel - Re: [PATCH v9 12/14] usb: hcd: Adapt to OTG core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 9 Jun 2016 10:27:40 +0300
From:	Roger Quadros <rogerq@...com>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
	<peter.chen@...escale.com>
CC:	<balbi@...nel.org>, <tony@...mide.com>,
	<gregkh@...uxfoundation.org>, <dan.j.williams@...el.com>,
	<mathias.nyman@...ux.intel.com>, <Joao.Pinto@...opsys.com>,
	<jun.li@...escale.com>, <grygorii.strashko@...com>,
	<yoshihiro.shimoda.uh@...esas.com>, <robh@...nel.org>,
	<nsekhar@...com>, <b-liu@...com>, <linux-usb@...r.kernel.org>,
	<linux-omap@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<devicetree@...r.kernel.org>
Subject: Re: [PATCH v9 12/14] usb: hcd: Adapt to OTG core

On 08/06/16 15:11, Sergei Shtylyov wrote:
> On 6/8/2016 3:06 PM, Roger Quadros wrote:
> 
>>>> Introduce usb_otg_add/remove_hcd() for use by host
>>>> controllers that are part of OTG/dual-role port.
>>>>
>>>> Non Device tree platforms can use the otg_dev argument
>>>> to specify the OTG controller device. If otg_dev is NULL
>>>> then the device tree node's otg-controller property is used to
>>>> get the otg_dev device.
>>>>
>>>> Signed-off-by: Roger Quadros <rogerq@...com>
>>>> Acked-by: Peter Chen <peter.chen@....com>
>>>> ---
>>>>  drivers/usb/core/hcd.c  | 55 +++++++++++++++++++++++++++++++++++++++++++++++++
>>>>  include/linux/usb/hcd.h |  4 ++++
>>>>  2 files changed, 59 insertions(+)
>>>>
>>>> diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c
>>>> index ae6c76d..c6f4155 100644
>>>> --- a/drivers/usb/core/hcd.c
>>>> +++ b/drivers/usb/core/hcd.c
>>> [...]
>>>> @@ -3025,6 +3030,56 @@ void usb_remove_hcd(struct usb_hcd *hcd)
>>>>  }
>>>>  EXPORT_SYMBOL_GPL(usb_remove_hcd);
>>>>
>>>> +static struct otg_hcd_ops otg_hcd_intf = {
>>>> +    .add = usb_add_hcd,
>>>> +    .remove = usb_remove_hcd,
>>>> +    .usb_bus_start_enum = usb_bus_start_enum,
>>>> +    .usb_control_msg = usb_control_msg,
>>>> +    .usb_hub_find_child = usb_hub_find_child,
>>>> +};
>>>> +
>>>> +/**
>>>> + * usb_otg_add_hcd - Register the HCD with OTG core.
>>>> + * @hcd: the usb_hcd structure to initialize
>>>> + * @irqnum: Interrupt line to allocate
>>>> + * @irqflags: Interrupt type flags
>>>> + * @otg_dev: OTG controller device managing this HCD
>>>
>>>    Device managing a driver? That's interesting. :-)
>>
>> Well it is the OTG controller instance really.
>> How else do you want me to write it?
> 
>   Just HC again? Or maybe HCI (HC interface)?

In my entire series HCD has always meant Host Controller Device.
I think I'll leave it the way it is.

cheers,
-roger