linux-kernel - Re: [PATCH] gpio: pca953x: Fix NBANK calculation for PCA9536

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdYZEbefjr-iHT3yahkBovFuE2Ofvr8_Mr+X++pJSVwzfA@mail.gmail.com>
Date:	Mon, 13 Jun 2016 09:22:27 +0200
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Vignesh R <vigneshr@...com>
Cc:	Alexandre Courbot <gnurou@...il.com>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] gpio: pca953x: Fix NBANK calculation for PCA9536

On Thu, Jun 9, 2016 at 7:32 AM, Vignesh R <vigneshr@...com> wrote:

> NBANK() macro assumes that ngpios is a multiple of 8(BANK_SZ) and
> hence results in 0 banks for PCA9536 which has just 4 gpios. This is
> wrong as PCA9356 has 1 bank with 4 gpios. This results in uninitialized
> PCA953X_INVERT register. Fix this by using DIV_ROUND_UP macro in
> NBANK().
>
> Cc: stable@...r.kernel.org
> Signed-off-by: Vignesh R <vigneshr@...com>

Patch applied.

Is this really a regression or affecting systems in development?

Which machine/device tree makes this problematic?

Yours,
Linus Walleij