linux-kernel - Re: [patch] IB/rxe: fix error code in rxe_srq_from

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAG9sBKN-XzPvhpFgxiBpB7FW6c0+PP7uF74zD4Had+368G9ViA@mail.gmail.com>
Date:	Mon, 13 Jun 2016 10:24:30 +0300
From:	Moni Shoua <monis@...lanox.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	Doug Ledford <dledford@...hat.com>,
	Sean Hefty <sean.hefty@...el.com>,
	Hal Rosenstock <hal.rosenstock@...il.com>,
	linux-rdma <linux-rdma@...r.kernel.org>,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [patch] IB/rxe: fix error code in rxe_srq_from_init()

On Mon, Jun 13, 2016 at 9:53 AM, Dan Carpenter <dan.carpenter@...cle.com> wrote:
> If copy_to_user() fails then it returns the number of bytes not copied.
> It would be between 1-4 here.  Later the callers dereference it leading
> to an Oops.
>
> It was sort of hard to fix this without making the code confusing so I
> did a little cleanup.
>
> Fixes: 443c15d23220 ('IB/rxe: Shared Receive Queue (SRQ) manipulation functions')
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

Thanks Dan
I'll merge it to next series