linux-kernel - Re: [PATCH 0/3] mm, thp: remove duplication and fix locking issues in swapin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160613135502.GI6518@dhcp22.suse.cz>
Date:	Mon, 13 Jun 2016 15:55:02 +0200
From:	Michal Hocko <mhocko@...nel.org>
To:	Ebru Akagunduz <ebru.akagunduz@...il.com>
Cc:	linux-mm@...ck.org, hughd@...gle.com, riel@...hat.com,
	akpm@...ux-foundation.org, kirill.shutemov@...ux.intel.com,
	n-horiguchi@...jp.nec.com, aarcange@...hat.com,
	iamjoonsoo.kim@....com, gorcunov@...nvz.org,
	linux-kernel@...r.kernel.org, mgorman@...e.de, rientjes@...gle.com,
	vbabka@...e.cz, aneesh.kumar@...ux.vnet.ibm.com,
	hannes@...xchg.org, boaz@...xistor.com
Subject: Re: [PATCH 0/3] mm, thp: remove duplication and fix locking issues
 in swapin

On Sat 11-06-16 22:21:06, Ebru Akagunduz wrote:
> On Fri, May 27, 2016 at 03:12:47PM +0200, Michal Hocko wrote:
[...]
> > IMHO we should drop the current ALLOCSTALL heuristic and replace it with
> > ~__GFP_DIRECT_RECLAIM.
>
> Actually, I don't lean towards to touch do_swap_page giving gfp parameter.
> do_swap_page is also used by do_page_fault, it can cause many side effect
> that I can't see. 

The point of the patch is to keep the current gfp mask from all places
except for the optimistic swapin. This was what my example patch did
AFAIR.
 
> I've just sent a patch series for converting from optimistic to
> conservative and take back allocstall. Maybe that way can be easier to
> be approved and less problemitical.

I will try to have a look but I will be travelling this week so cannot
promise anything.
-- 
Michal Hocko
SUSE Labs