linux-kernel - Re: [PATCH 2/8] tty: serial: fsl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cdeb3e9b-92c5-77d9-78ec-3af3954e8e16@toradex.com>
Date:	Tue, 14 Jun 2016 00:18:19 +0000
From:	Bhhuvanchandra DV <bhuvanchandra.dv@...adex.com>
To:	Shawn Guo <shawnguo@...nel.org>
CC:	<gregkh@...uxfoundation.org>, <linux-serial@...r.kernel.org>,
	<mturquette@...libre.com>, <sboyd@...eaurora.org>,
	<linux-kernel@...r.kernel.org>, <stefan@...er.ch>,
	<kernel@...gutronix.de>, <jslaby@...e.com>,
	<linux-clk@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>,
	<bhuvanchandra.dv@...adex.com>
Subject: Re: [PATCH 2/8] tty: serial: fsl_lpuart: support suspend/resume

Hi Shawn,

On 06/11/2016 02:03 PM, Shawn Guo wrote:

> On Thu, Jun 09, 2016 at 08:40:33PM +0530, Bhuvanchandra DV wrote:
>> From: Stefan Agner <stefan@...er.ch>
>>
>> In order to allow wake support in STOP sleep mode, clocks are
>> needed. Use imx_clk_gate2_cgr to disable automatic clock gating
>> in low power mode STOP. This allows to enable wake by UART using:
>> echo enabled > /sys/class/tty/ttyLP0/power/wakeup
>>
>> However, if wake is not enabled, the driver should disable the
>> clocks explicitly to save power.
>>
>> Signed-off-by: Stefan Agner <stefan@...er.ch>
>> ---
>>   drivers/clk/imx/clk-vf610.c     | 12 ++++++------
> Please send clock driver changes in a separate patch.

How about splitting this patchset to two? few patches are having minor
fixes and the few patches might need some review and discussions.
May be some thing like DMA fixes and the other minor fixes.

--
Bhuvan

>
> Shawn
>
>>   drivers/tty/serial/fsl_lpuart.c | 16 ++++++++++++++--
>>   2 files changed, 20 insertions(+), 8 deletions(-)