linux-kernel - Re: [PATCH 2/8] tty: serial: fsl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AF70EE92-9B41-4ECE-AB5F-E829E611B7C6@agner.ch>
Date:	Mon, 13 Jun 2016 19:42:10 -0700
From:	Stefan Agner <stefan@...er.ch>
To:	Bhhuvanchandra DV <bhuvanchandra.dv@...adex.com>,
	Shawn Guo <shawnguo@...nel.org>
CC:	gregkh@...uxfoundation.org, linux-serial@...r.kernel.org,
	mturquette@...libre.com, sboyd@...eaurora.org,
	linux-kernel@...r.kernel.org, kernel@...gutronix.de,
	jslaby@...e.com, linux-clk@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 2/8] tty: serial: fsl_lpuart: support suspend/resume



On June 13, 2016 5:18:19 PM PDT, Bhhuvanchandra DV <bhuvanchandra.dv@...adex.com> wrote:
>Hi Shawn,
>
>On 06/11/2016 02:03 PM, Shawn Guo wrote:
>
>> On Thu, Jun 09, 2016 at 08:40:33PM +0530, Bhuvanchandra DV wrote:
>>> From: Stefan Agner <stefan@...er.ch>
>>>
>>> In order to allow wake support in STOP sleep mode, clocks are
>>> needed. Use imx_clk_gate2_cgr to disable automatic clock gating
>>> in low power mode STOP. This allows to enable wake by UART using:
>>> echo enabled > /sys/class/tty/ttyLP0/power/wakeup
>>>
>>> However, if wake is not enabled, the driver should disable the
>>> clocks explicitly to save power.
>>>
>>> Signed-off-by: Stefan Agner <stefan@...er.ch>
>>> ---
>>>   drivers/clk/imx/clk-vf610.c     | 12 ++++++------
>> Please send clock driver changes in a separate patch.

The changes are dependet on each other, hence I put it in a single patch. But since it is a new feature it shouldn't really matter...

>
>How about splitting this patchset to two? few patches are having minor
>fixes and the few patches might need some review and discussions.
>May be some thing like DMA fixes and the other minor fixes.

I don't think that splitting up the patchset is necessary, with the current order it is possible to pick up the fixes independently...

--
Stefan

>
>--
>Bhuvan
>
>>
>> Shawn
>>
>>>   drivers/tty/serial/fsl_lpuart.c | 16 ++++++++++++++--
>>>   2 files changed, 20 insertions(+), 8 deletions(-)

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.