linux-kernel - linux-next: manual merge of the block tree with the btrfs tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20160614124451.25bbe808@canb.auug.org.au>
Date:	Tue, 14 Jun 2016 12:44:51 +1000
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	Jens Axboe <axboe@...nel.dk>, David Sterba <dsterba@...e.cz>
Cc:	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org,
	Mike Christie <mchristi@...hat.com>,
	Liu Bo <bo.li.liu@...cle.com>
Subject: linux-next: manual merge of the block tree with the btrfs tree

Hi Jens,

Today's linux-next merge of the block tree got a conflict in:

  fs/btrfs/extent_io.c

between commit:

  f338d193e1c5 ("Btrfs: fix eb memory leak due to readpage failure")

from the btrfs tree and commit:

  1f7ad75b13b5 ("btrfs: have submit_one_bio users use bio op accessors")

from the block tree.

I fixed it up (see below) and can carry the fix as necessary. This
is now fixed as far as linux-next is concerned, but any non trivial
conflicts should be mentioned to your upstream maintainer when your tree
is submitted for merging.  You may also want to consider cooperating
with the maintainer of the conflicting tree to minimise any particularly
complex conflicts.

-- 
Cheers,
Stephen Rothwell

diff --cc fs/btrfs/extent_io.c
index b8ecc6af4531,4f8bace0fd1b..000000000000
--- a/fs/btrfs/extent_io.c
+++ b/fs/btrfs/extent_io.c
@@@ -5253,18 -5225,9 +5251,18 @@@ int read_extent_buffer_pages(struct ext
  			err = __extent_read_full_page(tree, page,
  						      get_extent, &bio,
  						      mirror_num, &bio_flags,
- 						      READ | REQ_META);
+ 						      REQ_META);
 -			if (err)
 +			if (err) {
  				ret = err;
 +				/*
 +				 * We use &bio in above __extent_read_full_page,
 +				 * so we ensure that if it returns error, the
 +				 * current page fails to add itself to bio.
 +				 *
 +				 * We must dec io_pages by ourselves.
 +				 */
 +				atomic_dec(&eb->io_pages);
 +			}
  		} else {
  			unlock_page(page);
  		}