linux-kernel - Re: [PATCH] dax: use devm_add_action_or

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAA9_cmd3nsSsYyJFXZry=c1uP12R1aL7uz73Ey-aRc3CJGax-Q@mail.gmail.com>
Date:	Tue, 14 Jun 2016 16:28:43 -0700
From:	Dan Williams <dan.j.williams@...el.com>
To:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] dax: use devm_add_action_or_reset

On Sun, Jun 12, 2016 at 7:48 AM, Sudip Mukherjee
<sudipm.mukherjee@...il.com> wrote:
> If devm_add_action() fails we are explicitly calling the cleanup to free
> the resources allocated. Lets use the helper devm_add_action_or_reset()
> and return directly in case of error, as we know that the cleanup
> function has been already called by the helper if there was any error.
>
> Signed-off-by: Sudip Mukherjee <sudip.mukherjee@...ethink.co.uk>

Reviewed-by: Dan Williams <dan.j.williams@...el.com>

> ---
>
> There is no maintainer mentioned for this driver, so not sure who should
> this patch go through.

*raises hand*, I'll make sure MAINTAINERS gets updated, for this one
it seems Andrew has already taken it.  I notice that drivers/nvdimm/
could use the same cleanup.  I'll take a look unless you beat me to
it.