linux-kernel - Re: [PATCH] dax: use devm_add_action_or

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160615082326.GA1764@sudip-tp>
Date:	Wed, 15 Jun 2016 09:23:26 +0100
From:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
To:	Dan Williams <dan.j.williams@...el.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] dax: use devm_add_action_or_reset

On Tue, Jun 14, 2016 at 04:28:43PM -0700, Dan Williams wrote:
> On Sun, Jun 12, 2016 at 7:48 AM, Sudip Mukherjee
> <sudipm.mukherjee@...il.com> wrote:
> > If devm_add_action() fails we are explicitly calling the cleanup to free
> > the resources allocated. Lets use the helper devm_add_action_or_reset()
> > and return directly in case of error, as we know that the cleanup
> > function has been already called by the helper if there was any error.
> >
> > Signed-off-by: Sudip Mukherjee <sudip.mukherjee@...ethink.co.uk>
> 
> Reviewed-by: Dan Williams <dan.j.williams@...el.com>
> 
> > ---
> >
> > There is no maintainer mentioned for this driver, so not sure who should
> > this patch go through.
> 
> *raises hand*, I'll make sure MAINTAINERS gets updated, for this one
> it seems Andrew has already taken it.  I notice that drivers/nvdimm/
> could use the same cleanup.  I'll take a look unless you beat me to
> it.

I will give you an advantage in the race, i will not see that before
saturday. :)

Regards
Sudip