linux-kernel - Re: [PATCH v2 3/3] ARM64: dts: meson-gxbb: Add Hardware Random Generator node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <575F8F24.5000803@baylibre.com>
Date:	Tue, 14 Jun 2016 06:59:16 +0200
From:	Neil Armstrong <narmstrong@...libre.com>
To:	Kevin Hilman <khilman@...libre.com>
Cc:	Matt Mackall <mpm@...enic.com>,
	Herbert Xu <herbert@...dor.apana.org.au>,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-crypto@...r.kernel.org, linux-amlogic@...ts.infradead.org,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2 3/3] ARM64: dts: meson-gxbb: Add Hardware Random
 Generator node

On 06/14/2016 12:09 AM, Kevin Hilman wrote:
> Hi Neil,
> 
> Neil Armstrong <narmstrong@...libre.com> writes:
> 
>> Signed-off-by: Neil Armstrong <narmstrong@...libre.com>
>> ---
>>  arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 5 +++++
>>  1 file changed, 5 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
>> index 832815d..8353621 100644
>> --- a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
>> +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
>> @@ -167,6 +167,11 @@
>>  			};
>>  		};
>>  
>> +		rng {
>> +			compatible = "amlogic,meson-rng";
>> +			reg = <0x0 0xc8834000 0x0 0x4>;
>> +		};
> 
> This should be under the periphs bus, with an offset of 0x0 instead of
> at the top level.
> 
> See the for-next branch in the linux-amlogic tree[1] which has separate
> busses for periphs and hiu.

Yes, It was introduced lately.

Herbert,

I'll repost this patch separately to arm-soc directly rebased on [1].

Thanks,
Neil

> Kevin
> 
> [1] git://git.kernel.org/pub/scm/linux/kernel/git/khilman/linux-amlogic.git
>