linux-kernel - Re: [PATCH 4/5] reset: zynq: make it explicitly non-modular

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 14 Jun 2016 07:57:05 +0200
From:	Michal Simek <michal.simek@...inx.com>
To:	Paul Gortmaker <paul.gortmaker@...driver.com>,
	<linux-kernel@...r.kernel.org>
CC:	Philipp Zabel <p.zabel@...gutronix.de>,
	Michal Simek <michal.simek@...inx.com>,
	Sören Brinkmann <soren.brinkmann@...inx.com>,
	Moritz Fischer <moritz.fischer@...us.com>
Subject: Re: [PATCH 4/5] reset: zynq: make it explicitly non-modular

On 13.6.2016 20:03, Paul Gortmaker wrote:
> The Makefile/Kconfig currently controlling compilation of this code is:
> 
> drivers/reset/Makefile:obj-$(CONFIG_ARCH_ZYNQ) += reset-zynq.o
> arch/arm/mach:zynq/Kconfig:config ARCH_ZYNQ
> arch/arm/mach:zynq/Kconfig:     bool "Xilinx Zynq ARM Cortex A9 Platform" if ARCH_MULTI_V7
> 
> ...meaning that it currently is not being built as a module by anyone.
> 
> Lets remove the few remaining traces of modular macro usage, so that
> when reading the driver there is no doubt it is builtin-only.
> 
> Since module_platform_driver() uses the same init level priority as
> builtin_platform_driver() the init ordering remains unchanged with
> this commit.
> 
> We also delete the MODULE_LICENSE tag etc. since all that information
> was (or is now) contained at the top of the file in the comments.
> 
> Cc: Philipp Zabel <p.zabel@...gutronix.de>
> Cc: Michal Simek <michal.simek@...inx.com>
> Cc: "Sören Brinkmann" <soren.brinkmann@...inx.com>
> Cc: Moritz Fischer <moritz.fischer@...us.com>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com>
> ---
>  drivers/reset/reset-zynq.c | 10 ++++------
>  1 file changed, 4 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/reset/reset-zynq.c b/drivers/reset/reset-zynq.c
> index 138f2f205662..87a4e355578f 100644
> --- a/drivers/reset/reset-zynq.c
> +++ b/drivers/reset/reset-zynq.c
> @@ -3,6 +3,8 @@
>   *
>   * Xilinx Zynq Reset controller driver
>   *
> + * Author: Moritz Fischer <moritz.fischer@...us.com>
> + *
>   * This program is free software; you can redistribute it and/or modify
>   * it under the terms of the GNU General Public License as published by
>   * the Free Software Foundation; version 2 of the License.
> @@ -15,7 +17,7 @@
>  
>  #include <linux/err.h>
>  #include <linux/io.h>
> -#include <linux/module.h>
> +#include <linux/init.h>
>  #include <linux/mfd/syscon.h>
>  #include <linux/of.h>
>  #include <linux/platform_device.h>
> @@ -137,8 +139,4 @@ static struct platform_driver zynq_reset_driver = {
>  		.of_match_table	= zynq_reset_dt_ids,
>  	},
>  };
> -module_platform_driver(zynq_reset_driver);
> -
> -MODULE_LICENSE("GPL v2");
> -MODULE_AUTHOR("Moritz Fischer <moritz.fischer@...us.com>");
> -MODULE_DESCRIPTION("Zynq Reset Controller Driver");
> +builtin_platform_driver(zynq_reset_driver);
> 

Acked-by: Michal Simek <michal.simek@...inx.com>

Thanks,
Michal