Message-ID: <20160905222528.GX9950@windriver.com>
Date:   Mon, 5 Sep 2016 18:25:28 -0400
From:   Paul Gortmaker <paul.gortmaker@...driver.com>
To:     <linux-kernel@...r.kernel.org>,
        Philipp Zabel <p.zabel@...gutronix.de>
CC:     Antoine Tenart <antoine.tenart@...e-electrons.com>,
        Joachim Eastwood <manabian@...il.com>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Maxime Ripard <maxime.ripard@...e-electrons.com>,
        Michal Simek <michal.simek@...inx.com>,
        Moritz Fischer <moritz.fischer@...us.com>,
        Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
        Sören Brinkmann <soren.brinkmann@...inx.com>,
        Steffen Trumtrar <s.trumtrar@...gutronix.de>
Subject: Re: [PATCH 0/5] reset: make non-modular drivers really non modular

[[PATCH 0/5] reset: make non-modular drivers really non modular] On 13/06/2016 (Mon 14:03) Paul Gortmaker wrote:

> For anyone new to the underlying goal of this cleanup, we are trying to
> not use module support for code that can never be built as a module since:

Hi Phillip,

Wondering what the status of these patches is, since I didn't see them
in this recent merge in linux-next now that it has restarted again:

  ----------------------
  commit 7d3ef43f1f99d4250ff120c8965b3e5cd81b3c71
  Merge: 2b97f10b3896 cddb4800162e
  Author: Arnd Bergmann <arnd@...db.de>
  Date:   Fri Sep 2 18:29:04 2016 +0200

    Merge tag 'reset-for-4.9' of git://git.pengutronix.de/git/pza/linux into next/drivers
    
    Merge "Reset controller changes for v4.9" from Philipp Zabel:
  ----------------------

I believe there are at least two new instances in the reset drivers
since these original five were sent to you back in June.

The V1 didn't get any change requests, just some acks.  Do you want a
resend with the additional commits, and the Ack'd by from V1 added?

Thanks,
Paul.
--

> 
>  (1) it is easy to accidentally write unused module_exit and remove code
>  (2) it can be misleading when reading the source, thinking it can be
>      modular when the Makefile and/or Kconfig prohibit it
>  (3) it requires the include of the module.h header file which in turn
>      includes nearly everything else, thus adding to CPP overhead.
>  (4) it gets copied/replicated into other code and spreads like weeds.
> 
> Fortunately the reset dir is in pretty good shape, and there are only
> five instances of non-modular code using modular funcionality/macros.
> 
> Changes seen here cover the following categories:
> 
>   -just replacement of modular macros with their non-modular
>    equivalents that CPP would have inserted anyway
> 
>   -the removal of including module.h ; replaced with init.h
>    as required based on whether the file already had it.
> 
>   -the removal of any ".remove" functions that were hooked into
>    the driver struct.   This ".remove" function would of
>    course not be called from the __exit function since that was
>    never run.  However in theory, someone could have triggered it
>    via sysfs unbind, even though there isn't a sensible use case
>    for doing so.  So to cover that possibility, we've also disabled
>    sysfs unbind in the driver.
> 
> Recently several of these drivers got removal of the ".remove" fcns
> via other changes, so only one remains for which that happens here.
> 
> There are no initcall level changes here; everything was at the level
> of device_initcall and remains so, by using the builtin equivalents.
> 
> Build tested for several different key arch on a recent linux-next
> tree to ensure no silly typos crept in.
> 
> If there is a desire for any of these to be modular, we can definitely
> consider that, but by default the changes here keep the code consistent
> with existing behaviour and do not expand functionality into the modular
> realm that I can't run time test.
> 
> Paul.
> 
> ---
> 
> Cc: Antoine Tenart <antoine.tenart@...e-electrons.com>
> Cc: Joachim Eastwood <manabian@...il.com>
> Cc: Masahiro Yamada <yamada.masahiro@...ionext.com>
> Cc: Maxime Ripard <maxime.ripard@...e-electrons.com>
> Cc: Michal Simek <michal.simek@...inx.com>
> Cc: Moritz Fischer <moritz.fischer@...us.com>
> Cc: Philipp Zabel <p.zabel@...gutronix.de>
> Cc: Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>
> Cc: "Sören Brinkmann" <soren.brinkmann@...inx.com>
> Cc: Steffen Trumtrar <s.trumtrar@...gutronix.de>
> 
> 
> Paul Gortmaker (5):
>   reset: berlin: make it explicitly non-modular
>   reset: socfpga: make it explicitly non-modular
>   reset: sunxi: make it explicitly non-modular
>   reset: zynq: make it explicitly non-modular
>   reset: lpc18xx: make it explicitly non-modular
> 
>  drivers/reset/reset-berlin.c  | 12 ++++--------
>  drivers/reset/reset-lpc18xx.c | 32 +++++---------------------------
>  drivers/reset/reset-socfpga.c | 10 ++++------
>  drivers/reset/reset-sunxi.c   |  9 ++-------
>  drivers/reset/reset-zynq.c    | 10 ++++------
>  5 files changed, 19 insertions(+), 54 deletions(-)
> 
> -- 
> 2.8.4
> 

Powered by blists - more mailing lists