linux-kernel - RE: [PATCH v11 3/3] Bluetooth: hci_uart: Support firmware download for Marvell

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9744498ed55b499abebf95624ffcc664@SC-EXCH04.marvell.com>
Date:	Tue, 14 Jun 2016 06:35:37 +0000
From:	Amitkumar Karwar <akarwar@...vell.com>
To:	"linux-bluetooth@...r.kernel.org" <linux-bluetooth@...r.kernel.org>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Ganapathi Bhat" <gbhat@...vell.com>, Cathy Luo <cluo@...vell.com>
Subject: RE: [PATCH v11 3/3] Bluetooth: hci_uart: Support firmware download
 for Marvell

Hi Marcel,

> From: Amitkumar Karwar
> Sent: Monday, May 23, 2016 11:37 AM
> To: 'linux-bluetooth@...r.kernel.org'
> Cc: 'linux-kernel@...r.kernel.org'; Ganapathi Bhat; Cathy Luo
> Subject: RE: [PATCH v11 3/3] Bluetooth: hci_uart: Support firmware
> download for Marvell
> 
> Hi Marcel,
> 
> > > From: Amitkumar Karwar [mailto:akarwar@...vell.com]
> > > Sent: Friday, May 06, 2016 9:02 PM
> > > To: linux-bluetooth@...r.kernel.org
> > > Cc: linux-kernel@...r.kernel.org; Ganapathi Bhat; Amitkumar Karwar
> > > Subject: [PATCH v11 3/3] Bluetooth: hci_uart: Support firmware
> > > download for Marvell
> > >
> > > From: Ganapathi Bhat <gbhat@...vell.com>
> > >
> > > This patch implement firmware download feature for Marvell Bluetooth
> > > devices. If firmware is already downloaded, it will skip
> downloading.
> > >
> > > Signed-off-by: Ganapathi Bhat <gbhat@...vell.com>
> > > Signed-off-by: Amitkumar Karwar <akarwar@...vell.com>
> > > ---
> > > v2: Fixed compilation warning reported by kbuild test robot
> > > v3: Addressed review comments from Marcel Holtmann
> > >     a) Removed vendor specific code from hci_ldisc.c
> > >     b) Get rid of static forward declaration
> > >     c) Removed unnecessary heavy nesting
> > >     d) Git rid of module parameter and global variables
> > >     e) Add logic to pick right firmware image
> > > v4: Addresses review comments from Alan
> > >     a) Use existing kernel helper APIs instead of writing own.
> > >     b) Replace mdelay() with msleep()
> > > v5: Addresses review comments from Loic Poulain
> > >     a) Use bt_dev_err/warn/dbg helpers insted of BT_ERR/WARN/DBG
> > >     b) Used static functions where required and removed forward
> > > delcarations
> > >     c) Edited comments for the function hci_uart_recv_data
> > >     d) Made HCI_UART_DNLD_FW flag a part of driver private data
> > > v6: Addresses review comments from Loic Poulain
> > >     a) Used skb instead of array to store firmware data during
> > download
> > >     b) Used hci_uart_tx_wakeup and enqueued packets instead of tty
> > write
> > >     c) Used GFP_KERNEL instead of GFP_ATOMIC
> > > v7: Edited Kconfig to add dependency for BT_HCIUART_H4. The change
> > > resolves
> > >     errors reported by kbuild test robot.
> > > v8: Addressed review comments from Marcel Holtmann
> > >     a) Removed unnecessary memory allocation failure messages
> > >     b) Get rid of btmrvl.h header file and add definitions in
> > > hci_mrvl.c file
> > > v9: Addressed review comments from Marcel Holtmann
> > >     a) Moved firmware download code from setup to prepare handler.
> > >     b) Change messages from bt_dev_*->BT_*, as hdev isn't available
> > > during firmware
> > >      download.
> > > v10: Addressed review comments from Marcel Holtmann
> > >     a) Added new callback recv_for_prepare to receive data from
> device
> > >      during prepare phase
> > >     b) Avoided using private flags (HCI_UART_DNLD_FW) as new receive
> > > callback is
> > >      added for the same purpose
> > >     c) Used kernel API to handle unaligned data
> > >     d) Moved mrvl_set_baud functionality inside setup callback
> > > v11: Write data through ldisc in mrvl_send_ack() instead of directly
> > > calling
> > >     write method(One Thousand Gnomes).
> >
> 
> Could you please take this patch?
> 

This has been pending for a while.
Please let me know your comment.

Regards,
Amitkumar