linux-kernel - Re: lm-senser can't detect thermal on thermal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1465885934.4001.4.camel@intel.com>
Date:	Tue, 14 Jun 2016 14:32:14 +0800
From:	Zhang Rui <rui.zhang@...el.com>
To:	Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
Cc:	"edubezval@...il.com" <edubezval@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-renesas-soc@...r.kernel.org" 
	<linux-renesas-soc@...r.kernel.org>,
	"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
	"yoshihiro.shimoda.uh@...esas.com" <yoshihiro.shimoda.uh@...esas.com>,
	"cm-hiep@...so.co.jp" <cm-hiep@...so.co.jp>
Subject: Re: lm-senser can't detect thermal on thermal_zone

On Thu, 2016-06-09 at 03:07 +0000, Kuninori Morimoto wrote:
> 
> Hi Zhang
> 
> Can you check this email ?
> 
> > 
> > > 
> > > Thank you for your help
> > > 
> > > > 
> > > > > 
> > > > > 	non thermal-zon
> > > > > 	  sensor command: OK
> > > > > 	  read from /sys/class/thermal/thermal_zone0 : OK
> > > > > 
> > > > > 	thermal-zon
> > > > > 	  sensor command: NG
> > > > > 	  read from /sys/class/thermal/thermal_zone0 : OK
> > > > config THERMAL_HWMON
> > > >         bool
> > > >         prompt "Expose thermal sensors as hwmon device"
> > > >         depends on HWMON=y || HWMON=THERMAL
> > > >         default y
> > > > 
> > > > please check if the thermal subsystem is built in, while hwmon
> > > > subsystem
> > > > is built as module.
> > > > you should either set CONFIG_HWMON=y, or set both CONFIG_HWMON
> > > > and
> > > > CONFIG_THERMAL as module.
> > > Thanks. but it seems our system has it.
> > > 
> > > I noticed that thermal_zone case uses of_parse_thermal_zones()
> > > and it has this.
> > > 
> > > 		/* No hwmon because there might be hwmon drivers
> > > registering */
> > > 		tzp->no_hwmon = true;
> > > 
> > > and on thermal_zone_device_register() check this for hwmon
> > > 
> > > struct thermal_zone_device *thermal_zone_device_register(xxxx)
> > > {
> > > 	...
> > > 	if (!tz->tzp || !tz->tzp->no_hwmon) {
> > > 		result = thermal_add_hwmon_sysfs(tz);
> > > 		...
> > > 	}
> > > 	...
> > > }
> > > 
> > > Does this mean "thermal_zone doesn't use lm-senser" ?

I'd prefer to say of_thermal registered thermal_zone doesn't use lm-
sensor.
If you're really want to see hwmon interface, I think you should use
thermal API (thermal_zone_device_register) directly.

thanks,
rui