linux-kernel - Re: [PATCH] phy: rockchip-dp: fix return value check in rockchip_dp_phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4354296.6MbJoqdM2Z@diego>
Date:	Tue, 14 Jun 2016 08:39:57 +0200
From:	Heiko Stübner <heiko@...ech.de>
To:	weiyj_lk@....com
Cc:	Kishon Vijay Abraham I <kishon@...com>,
	Wei Yongjun <yongjun_wei@...ndmicro.com.cn>,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-rockchip@...ts.infradead.org
Subject: Re: [PATCH] phy: rockchip-dp: fix return value check in rockchip_dp_phy_probe()

Am Montag, 13. Juni 2016, 23:31:47 schrieb weiyj_lk@....com:
> From: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
> 
> In case of error, the function devm_kzalloc() returns NULL pointer
> not ERR_PTR(). The IS_ERR() test in the return value check should
> be replaced with NULL test.
> 
> Signed-off-by: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>

obviously correct, thanks for catching.

Reviewed-by: Heiko Stuebner <heiko@...ech.de>