linux-kernel - Re: [PATCH] phy: rockchip-dp: fix return value check in rockchip_dp_phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 17 Jun 2016 18:45:18 +0530
From:	Kishon Vijay Abraham I <kishon@...com>
To:	Heiko Stübner <heiko@...ech.de>,
	<weiyj_lk@....com>
CC:	Wei Yongjun <yongjun_wei@...ndmicro.com.cn>,
	<linux-kernel@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>,
	<linux-rockchip@...ts.infradead.org>
Subject: Re: [PATCH] phy: rockchip-dp: fix return value check in
 rockchip_dp_phy_probe()



On Tuesday 14 June 2016 12:09 PM, Heiko Stübner wrote:
> Am Montag, 13. Juni 2016, 23:31:47 schrieb weiyj_lk@....com:
>> From: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
>>
>> In case of error, the function devm_kzalloc() returns NULL pointer
>> not ERR_PTR(). The IS_ERR() test in the return value check should
>> be replaced with NULL test.
>>
>> Signed-off-by: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
> 
> obviously correct, thanks for catching.
> 
> Reviewed-by: Heiko Stuebner <heiko@...ech.de>

applied, thanks.

-Kishon