linux-kernel - Re: [PATCH v2 1/2] memory: tegra: mc: Add missing of_node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160614093600.GA22567@ulmo.ba.sec>
Date:	Tue, 14 Jun 2016 11:36:00 +0200
From:	Thierry Reding <thierry.reding@...il.com>
To:	Amitoj Kaur Chawla <amitoj1606@...il.com>
Cc:	swarren@...dotorg.org, gnurou@...il.com,
	linux-tegra@...r.kernel.org, linux-kernel@...r.kernel.org,
	julia.lawall@...6.fr
Subject: Re: [PATCH v2 1/2] memory: tegra: mc: Add missing of_node_put

On Mon, Jan 25, 2016 at 10:53:07PM +0530, Amitoj Kaur Chawla wrote:
> for_each_child_of_node performs an of_node_get on each iteration, so
> to break out of the loop an of_node_put is required.
> 
> Found using Coccinelle. The semantic patch used for this is as follows:
> 
> // <smpl>
> @@
> expression e;
> local idexpression n;
> @@
> 
>  for_each_child_of_node(..., n) {
>    ... when != of_node_put(n)
>        when != e = n
> (
>    return n;
> |
> +  of_node_put(n);
> ?  return ...;
> )
>    ...
>  }
> // </smpl
> 
> Signed-off-by: Amitoj Kaur Chawla <amitoj1606@...il.com>
> ---
> Changes in v2:
>         -None
> 
> There is also an extra of_node_put() before a continue in the same loop
> on line 212 of this file which should be deleted. Julia Lawall has
> already sent a patch to delete this but if preferred I can send one patch to 
> do both the changes.
> 
>  drivers/memory/tegra/mc.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)

Applied, thanks.

Thierry

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)