linux-kernel - Re: lm-senser can't detect thermal on thermal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1465910658.9422.9.camel@intel.com>
Date:	Tue, 14 Jun 2016 21:24:18 +0800
From:	Zhang Rui <rui.zhang@...el.com>
To:	Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
Cc:	"edubezval@...il.com" <edubezval@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-renesas-soc@...r.kernel.org" 
	<linux-renesas-soc@...r.kernel.org>,
	"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
	"yoshihiro.shimoda.uh@...esas.com" <yoshihiro.shimoda.uh@...esas.com>,
	"cm-hiep@...so.co.jp" <cm-hiep@...so.co.jp>
Subject: Re: lm-senser can't detect thermal on thermal_zone

On 二, 2016-06-14 at 07:03 +0000, Kuninori Morimoto wrote:
> Hi Zhang
> 
> > 
> > > 
> > > > 
> > > > > 
> > > > > struct thermal_zone_device
> > > > > *thermal_zone_device_register(xxxx)
> > > > > {
> > > > > 	...
> > > > > 	if (!tz->tzp || !tz->tzp->no_hwmon) {
> > > > > 		result = thermal_add_hwmon_sysfs(tz);
> > > > > 		...
> > > > > 	}
> > > > > 	...
> > > > > }
> > > > > 
> > > > > Does this mean "thermal_zone doesn't use lm-senser" ?
> > I'd prefer to say of_thermal registered thermal_zone doesn't use
> > lm-
> > sensor.
> > If you're really want to see hwmon interface, I think you should
> > use
> > thermal API (thermal_zone_device_register) directly.
> Thank you for your feedback.
> My driver is supporting both of_thermal and thermal API.
> So, switching is not a big deal.
> 
> But can you teach me why of_thermal doesn't use lm-senser ??

I don't know if there is a solid reason that we can not expose the
hwmon interface. But just like the comment says, "/* No hwmon because
there might be hwmon drivers registering */", given that of_thermal
just parses THERMAL data of device tree, it is reasonable to me for
exposing thermal interfaces only.

thanks,
rui