linux-kernel - Re: lm-senser can't detect thermal on thermal

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87r3bykmxy.wl%kuninori.morimoto.gx@renesas.com>
Date:	Thu, 16 Jun 2016 00:23:12 +0000
From:	Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>
To:	Zhang Rui <rui.zhang@...el.com>
CC:	"edubezval@...il.com" <edubezval@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-renesas-soc@...r.kernel.org" 
	<linux-renesas-soc@...r.kernel.org>,
	"linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
	"yoshihiro.shimoda.uh@...esas.com" <yoshihiro.shimoda.uh@...esas.com>,
	"cm-hiep@...so.co.jp" <cm-hiep@...so.co.jp>
Subject: Re: lm-senser can't detect thermal on thermal_zone


Hi Zhang

Thank you for your feedback

> > > > > > *thermal_zone_device_register(xxxx)
> > > > > > {
> > > > > > 	...
> > > > > > 	if (!tz->tzp || !tz->tzp->no_hwmon) {
> > > > > > 		result = thermal_add_hwmon_sysfs(tz);
> > > > > > 		...
> > > > > > 	}
> > > > > > 	...
> > > > > > }
(snip)
> I don't know if there is a solid reason that we can not expose the
> hwmon interface. But just like the comment says, "/* No hwmon because
> there might be hwmon drivers registering */", given that of_thermal
> just parses THERMAL data of device tree, it is reasonable to me for
> exposing thermal interfaces only.

I see.
I will re-consider my driver, and will send patch.
Thanks