[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20160616002024.GO28218@codeaurora.org>
Date: Wed, 15 Jun 2016 17:20:24 -0700
From: Stephen Boyd <sboyd@...eaurora.org>
To: Linus Walleij <linus.walleij@...aro.org>
Cc: lee.jones@...aro.org, linux-kernel@...r.kernel.org,
Bjorn Andersson <bjorn.andersson@...aro.org>,
stable@...r.kernel.org
Subject: Re: [PATCH v3] mfd: qcom_rpm: fix offset error for msm8660
On 06/15, Linus Walleij wrote:
> @@ -426,10 +447,11 @@ static irqreturn_t qcom_rpm_ack_interrupt(int irq, void *dev)
> u32 ack;
> int i;
>
> - ack = readl_relaxed(RPM_CTRL_REG(rpm, RPM_ACK_CONTEXT));
> - for (i = 0; i < RPM_SELECT_SIZE; i++)
> - writel_relaxed(0, RPM_CTRL_REG(rpm, RPM_ACK_SELECTOR + i));
> - writel(0, RPM_CTRL_REG(rpm, RPM_ACK_CONTEXT));
> + ack = readl_relaxed(RPM_CTRL_REG(rpm, rpm->data->ack_ctx_off));
> + for (i = 0; i < rpm->data->sel_size; i++)
> + writel_relaxed(0,
> + RPM_CTRL_REG(rpm, rpm->data->ack_sel_off + i));
> + writel(0, RPM_CTRL_REG(rpm, rpm->data->ack_ctx_off));
Does the ack size vary though? I thought that was always 7. It
seems that really only the request selector size varies?
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
Powered by blists - more mailing lists