linux-kernel - Re: disfunctional floppy driver in kernels 4.5, 4.6 and 4.7

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160614190923.GX14480@ZenIV.linux.org.uk>
Date:	Tue, 14 Jun 2016 20:09:23 +0100
From:	Al Viro <viro@...IV.linux.org.uk>
To:	Jiri Kosina <jikos@...nel.org>
Cc:	Wim Osterholt <wim@....tudelft.nl>, linux-kernel@...r.kernel.org
Subject: Re: disfunctional floppy driver in kernels 4.5, 4.6 and 4.7

On Mon, Jun 13, 2016 at 02:15:15PM +0200, Jiri Kosina wrote:

> Hmm, could you please test with 09954bad448 reverted? (although I don't 
> really have a good explanation currently how it'd be causing what you are 
> observing).

I do, actually - ->f_mode on open(..., 3) contains neither FMODE_READ nor
FMODE_WRITE.  So this
    While at it, clean up a bit handling of !(mode & (FMODE_READ|FMODE_WRITE))
    case and return EINVAL instead of succeeding as well.
is working as promised in commit message.