linux-kernel - Re: [PATCH] selftests/exec: Add Makefile to install list since exec test expect it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <57605679.7080401@osg.samsung.com>
Date:	Tue, 14 Jun 2016 13:09:45 -0600
From:	Shuah Khan <shuahkh@....samsung.com>
To:	Yannick Brosseau <scientist@...com>,
	linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:	kernel-team@...com, Shuah Khan <shuahkh@....samsung.com>
Subject: Re: [PATCH] selftests/exec: Add Makefile to install list since exec
 test expect it

On 06/14/2016 12:45 PM, Yannick Brosseau wrote:
> When running the execveat test once installed, the Makefile it not available and the
> test fail. Bundling the Makefile file with the installed files fix that.

Install is for installing kselftest binaries and run-time dependencies
if any on a target system. It is not for being able to build it on the
target. Bundling Makefile doesn't make sense.

-- Shuah

> 
> Signed-off-by: Yannick Brosseau <scientist@...com>
> ---
>  tools/testing/selftests/exec/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/exec/Makefile b/tools/testing/selftests/exec/Makefile
> index 4e400eb..d2be580 100644
> --- a/tools/testing/selftests/exec/Makefile
> +++ b/tools/testing/selftests/exec/Makefile
> @@ -1,6 +1,6 @@
>  CFLAGS = -Wall
>  BINARIES = execveat
> -DEPS = execveat.symlink execveat.denatured script subdir
> +DEPS = execveat.symlink execveat.denatured script subdir Makefile
>  all: $(BINARIES) $(DEPS)
>  
>  subdir:
>