linux-kernel - Re: [PATCH] selftests/exec: Add Makefile to install list since exec test expect it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ce531f7a-bb10-1be2-e8d4-7a1fdbd7821c@fb.com>
Date:	Tue, 14 Jun 2016 12:15:17 -0700
From:	Yannick Brosseau <scientist@...com>
To:	Shuah Khan <shuahkh@....samsung.com>,
	<linux-kselftest@...r.kernel.org>, <linux-kernel@...r.kernel.org>
CC:	<kernel-team@...com>
Subject: Re: [PATCH] selftests/exec: Add Makefile to install list since exec
 test expect it

On 06/14/2016 12:09 PM, Shuah Khan wrote:
> On 06/14/2016 12:45 PM, Yannick Brosseau wrote:
>> When running the execveat test once installed, the Makefile it not available and the
>> test fail. Bundling the Makefile file with the installed files fix that.
> Install is for installing kselftest binaries and run-time dependencies
> if any on a target system. It is not for being able to build it on the
> target. Bundling Makefile doesn't make sense.
The test tries to exec the Makefile file:
    fail += check_execveat_fail(dot_dfd, "Makefile", 0, EACCES);

So it's a runtime dependency at the moment.
We can either change the test to try to open another file or add the
Makefile

Yannick





> -- Shuah
>
>> Signed-off-by: Yannick Brosseau <scientist@...com>
>> ---
>>  tools/testing/selftests/exec/Makefile | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tools/testing/selftests/exec/Makefile b/tools/testing/selftests/exec/Makefile
>> index 4e400eb..d2be580 100644
>> --- a/tools/testing/selftests/exec/Makefile
>> +++ b/tools/testing/selftests/exec/Makefile
>> @@ -1,6 +1,6 @@
>>  CFLAGS = -Wall
>>  BINARIES = execveat
>> -DEPS = execveat.symlink execveat.denatured script subdir
>> +DEPS = execveat.symlink execveat.denatured script subdir Makefile
>>  all: $(BINARIES) $(DEPS)
>>  
>>  subdir:
>>