linux-kernel - Re: [PATCH] selftests/exec: Add Makefile to install list since exec test expect it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5760595F.4040502@osg.samsung.com>
Date:	Tue, 14 Jun 2016 13:22:07 -0600
From:	Shuah Khan <shuahkh@....samsung.com>
To:	Yannick Brosseau <scientist@...com>,
	linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:	kernel-team@...com
Subject: Re: [PATCH] selftests/exec: Add Makefile to install list since exec
 test expect it

On 06/14/2016 01:15 PM, Yannick Brosseau wrote:
> On 06/14/2016 12:09 PM, Shuah Khan wrote:
>> On 06/14/2016 12:45 PM, Yannick Brosseau wrote:
>>> When running the execveat test once installed, the Makefile it not available and the
>>> test fail. Bundling the Makefile file with the installed files fix that.
>> Install is for installing kselftest binaries and run-time dependencies
>> if any on a target system. It is not for being able to build it on the
>> target. Bundling Makefile doesn't make sense.
> The test tries to exec the Makefile file:
>     fail += check_execveat_fail(dot_dfd, "Makefile", 0, EACCES);
> 
> So it's a runtime dependency at the moment.
> We can either change the test to try to open another file or add the
> Makefile

Ah I see why Makefile is necessary. No point in adding a new file.
Please add a comment in the file to indicate that Makefile is a
run-time dependency. Could you also rephrase the change log to make
it clear that Makefile is run-time dependency.

Thanks for catching it.

-- Shuah