[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20160615205311.GB19822@pd.tnic>
Date: Wed, 15 Jun 2016 22:53:11 +0200
From: Borislav Petkov <bp@...en8.de>
To: "Vesely, Jan" <Jan.Vesely@....com>
Cc: "joro@...tes.org" <joro@...tes.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"iommu@...ts.linux-foundation.org" <iommu@...ts.linux-foundation.org>
Subject: Re: [PATCH 2/2] iommu/amd: Destroy api_lock mutex when freeing domain
On Wed, Jun 15, 2016 at 05:53:15PM +0000, Vesely, Jan wrote:
> There are no specific bugs/oopses that these patches fix (that I'm
> aware of). Both were found while I was familiarizing myself with the
> code looking for memory corruption (which turned out to be [0]).
> Either issue would be very difficult to hit in the wild and
> mutex_destroy is empty unless you compile using CONFIG_DEBUG_MUTEXES.
See Documentation/SubmittingPatches which explains what "Fixes:" means.
That same file also contains info in section 2) how to write commit
messages.
Please read it, it'll help you significantly if you're planning on
sending more patches to LKML.
> [0] https://lkml.org/lkml/2016/3/7/1087
Oh, and also, please don't use any web pages archiving lkml as pointers
but the kernel.org redirector:
http://lkml.kernel.org/r/<Message-ID>
or
http://lkml.kernel.org/g/<Message-ID>
(that second one redirects to gmane)
HTH.
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
Powered by blists - more mailing lists