linux-kernel - Re: [PATCH 2/2] iommu/amd: Destroy api

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1467132531.2590.158.camel@amd.com>
Date:	Tue, 28 Jun 2016 16:48:54 +0000
From:	"Vesely, Jan" <Jan.Vesely@....com>
To:	"bp@...en8.de" <bp@...en8.de>
CC:	"joro@...tes.org" <joro@...tes.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"iommu@...ts.linux-foundation.org" <iommu@...ts.linux-foundation.org>
Subject: Re: [PATCH 2/2] iommu/amd: Destroy api_lock mutex when freeing domain

On Wed, 2016-06-15 at 22:53 +0200, Borislav Petkov wrote:
> On Wed, Jun 15, 2016 at 05:53:15PM +0000, Vesely, Jan wrote:
> > There are no specific bugs/oopses that these patches fix (that I'm
> > aware of). Both were found while I was familiarizing myself with
> > the
> > code looking for memory corruption (which turned out to be [0]).
> > Either issue would be very difficult to hit in the wild and
> > mutex_destroy is empty unless you compile using
> > CONFIG_DEBUG_MUTEXES.
> 
> See Documentation/SubmittingPatches which explains what "Fixes:"
> means.
> 
> That same file also contains info in section 2) how to write commit
> messages.
> 
> Please read it, it'll help you significantly if you're planning on
> sending more patches to LKML.

Hi,

thanks for all the hints. I'll try to revisit and update the patches
soon (might take few weeks though). Kernel development is not my
(current) job and other subsystems don't have these requirements, if
submissions need more than just git send-email of existing fixes
dedicating extra time is difficult.

Jan

> 
> > [0] https://lkml.org/lkml/2016/3/7/1087
> 
> Oh, and also, please don't use any web pages archiving lkml as
> pointers
> but the kernel.org redirector:
> 
> http://lkml.kernel.org/r/<Message-ID>;
> 
> or
> 
> http://lkml.kernel.org/g/<Message-ID>;
> 
> (that second one redirects to gmane)
> 
> HTH.
>