linux-kernel - Re: [PATCH V2] block: correctly fallback for zeroout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20160615212617.GB5410@sucs.org>
Date:	Wed, 15 Jun 2016 22:26:17 +0100
From:	Sitsofe Wheeler <sitsofe@...il.com>
To:	Shaohua Li <shli@...com>
Cc:	linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
	axboe@...com, snitzer@...hat.com, martin.petersen@...cle.com,
	hch@...radead.org, Kernel-team@...com,
	Dan Carpenter <dan.carpenter@...cle.com>
Subject: Re: [PATCH V2] block: correctly fallback for zeroout

On Tue, Jun 07, 2016 at 07:58:25AM -0700, Shaohua Li wrote:
>
> I didn't follow. io_err is only and always set when ret == 0. io_err is
> meanless if ret != 0, because that means the disk doesn't support discard and
> we don't dispatch discard IO. why should we initialized io_err to 0?

My mistake - I confused what !ret would mean.

Unfortunately the V2 patch no longer cleanly applies to the latest
kernel (db06d759d6cf903aeda8c107fd3abd366dd80200 ) so I can't easily
test it there.

-- 
Sitsofe | http://sucs.org/~sits/