linux-kernel - Re: [PATCH v2 3/4] input: touchscreen: mxs-lradc: Add support for touchscreen

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1443695961.58810.3de61248-4cae-4f94-b8a2-ef63c5c3ec1b.open-xchange@email.1und1.de>
Date:	Wed, 15 Jun 2016 23:26:18 +0200 (CEST)
From:	Stefan Wahren <stefan.wahren@...e.com>
To:	Ksenija Stanojevic <ksenija.stanojevic@...il.com>,
	linux-kernel@...r.kernel.org
Cc:	lee.jones@...aro.org, linux-input@...r.kernel.org,
	pmeerw@...erw.net, jic23@...nel.org, knaack.h@....de,
	lars@...afoo.de, dmitry.torokhov@...il.com, harald@...ib.org,
	fabio.estevam@...escale.com, linux-iio@...r.kernel.org,
	marex@...x.de
Subject: Re: [PATCH v2 3/4] input: touchscreen: mxs-lradc: Add support for
 touchscreen

Hi,

unfortunately i still don't have a touchscreen to test this patch.

> Ksenija Stanojevic <ksenija.stanojevic@...il.com> hat am 8. Juni 2016 um 16:48
> geschrieben:
> 
> 
> Add 4-wire/5-wire touchscreen controller.
> 
> Signed-off-by: Ksenija Stanojevic <ksenija.stanojevic@...il.com>
> ---
> Changes in v2:
>  - do not change spacing in Kconfig
>  - remove dev.parent
>  - rename err_ts_register to error
>  - combine functions hw_stop and disable_ts so that mxs_lradc_ts_remove
>    could be deleted.
>  - add spinlock in struct mxs_lradc_ts to enable locking in interrupt handler.
>  - only grab irqs that are relevant to touchscreen
>  - use direct return instead assigning error to touch_ret in probe function.
>  - change licence to GPL
>  - add copyright
> 
>  drivers/input/touchscreen/Kconfig        |  10 +
>  drivers/input/touchscreen/Makefile       |   1 +
>  drivers/input/touchscreen/mxs-lradc-ts.c | 726
> +++++++++++++++++++++++++++++++
>  3 files changed, 737 insertions(+)
>  create mode 100644 drivers/input/touchscreen/mxs-lradc-ts.c
> 
> diff --git a/drivers/input/touchscreen/mxs-lradc-ts.c
> b/drivers/input/touchscreen/mxs-lradc-ts.c
> new file mode 100644
> index 0000000..778bb61
> --- /dev/null
> +++ b/drivers/input/touchscreen/mxs-lradc-ts.c
> @@ -0,0 +1,726 @@
> +/*
> + * Freescale MXS LRADC driver

touchscreen driver

> + *
> + * Copyright (c) 2012 DENX Software Engineering, GmbH.
> + * Marek Vasut <marex@...x.de>
> + * Ksenija Stanojevic <ksenija.stanojevic@...il.com>
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> + * GNU General Public License for more details.
> + */
> +
> ...
> +
> +static struct platform_driver mxs_lradc_ts_driver = {
> +	.driver	= {
> +		.name = DRIVER_NAME_TS,
> +	},
> +	.probe	= mxs_lradc_ts_probe,
> +};
> +module_platform_driver(mxs_lradc_ts_driver);
> +

MODULE_DESCRIPTION ?
MODULE_AUTHOR ?

> +MODULE_LICENSE("GPL");
> -- 
> 1.9.1
>