[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <5245411.kmNEkqpVVS@wuerfel>
Date: Wed, 15 Jun 2016 23:25:13 +0200
From: Arnd Bergmann <arnd@...db.de>
To: Jes Sorensen <Jes.Sorensen@...hat.com>
Cc: Kalle Valo <kvalo@...eaurora.org>,
Larry Finger <Larry.Finger@...inger.net>,
Chaoming Li <chaoming_li@...lsil.com.cn>,
linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rtlwifi: use s8 instead of char
On Wednesday, June 15, 2016 5:10:51 PM CEST Jes Sorensen wrote:
>
> Arnd,
>
> rtlwifi and rtl8xxxu are two distinct drivers managed by different
> people. I'd be really nice if you could split this into a per driver
> patch.
>
> That said, the use of char in rtl8xxxu is all as a flag indicator, so I
> don't think the s/char/s8/ conversion is justified. I used char rather
> than ugly bool to reduce the size of the struct.
Makes sense, I'll resend without that change. If anything, the flag
should become u8, not s8 anyway.
Arnd
Powered by blists - more mailing lists