lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 16 Jun 2016 16:02:38 +0000 From: David Laight <David.Laight@...LAB.COM> To: 'Arnd Bergmann' <arnd@...db.de>, Jes Sorensen <Jes.Sorensen@...hat.com> CC: Kalle Valo <kvalo@...eaurora.org>, Larry Finger <Larry.Finger@...inger.net>, Chaoming Li <chaoming_li@...lsil.com.cn>, "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: RE: [PATCH] rtlwifi: use s8 instead of char From: Arnd Bergmann > On Wednesday, June 15, 2016 5:10:51 PM CEST Jes Sorensen wrote: > > > > Arnd, > > > > rtlwifi and rtl8xxxu are two distinct drivers managed by different > > people. I'd be really nice if you could split this into a per driver > > patch. > > > > That said, the use of char in rtl8xxxu is all as a flag indicator, so I > > don't think the s/char/s8/ conversion is justified. I used char rather > > than ugly bool to reduce the size of the struct. > > Makes sense, I'll resend without that change. If anything, the flag > should become u8, not s8 anyway. Does bool:8 work ? David
Powered by blists - more mailing lists