linux-kernel - Re: [PATCH 16/27] mm: Move page mapped accounting to the node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20160616160448.GL1868@techsingularity.net>
Date:	Thu, 16 Jun 2016 17:04:48 +0100
From:	Mel Gorman <mgorman@...hsingularity.net>
To:	Vlastimil Babka <vbabka@...e.cz>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Linux-MM <linux-mm@...ck.org>, Rik van Riel <riel@...riel.com>,
	Johannes Weiner <hannes@...xchg.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 16/27] mm: Move page mapped accounting to the node

On Thu, Jun 16, 2016 at 05:52:59PM +0200, Vlastimil Babka wrote:
> On 06/09/2016 08:04 PM, Mel Gorman wrote:
> >Reclaim makes decisions based on the number of file pages that are mapped but
> >it's mixing node and zone information. Account NR_FILE_MAPPED pages on the node.
> 
> And NR_ANON_PAGES.
> 

Yes.

> >Signed-off-by: Mel Gorman <mgorman@...hsingularity.net>
> 
> Acked-by: Vlastimil Babka <vbabka@...e.cz>
> 
> I've noticed some new "page_zone(page)->zone_pgdat" instances here.
> 

FWIW, I created a page_pgdat helper and converted all patterns like this
introduced by the series to the helper. There are other potential users
of the helper in the tree that are not touched by the patches but I left
them to preserve history.

-- 
Mel Gorman
SUSE Labs