linux-kernel - Re: [PATCH] mm: compaction: fix dummy declarations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20160615144825.79274c2b6ac1625eb42002d1@linux-foundation.org>
Date:	Wed, 15 Jun 2016 14:48:25 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Minchan Kim <minchan@...nel.org>, Vlastimil Babka <vbabka@...e.cz>,
	Michal Hocko <mhocko@...e.com>,
	Hillf Danton <hillf.zj@...baba-inc.com>,
	Mel Gorman <mgorman@...hsingularity.net>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm: compaction: fix dummy declarations

On Wed, 15 Jun 2016 23:39:12 +0200 Arnd Bergmann <arnd@...db.de> wrote:

> We get a build error in several test builds after a recent code rework:
> 
> In file included from include/linux/balloon_compaction.h:48:0,
>                  from mm/balloon_compaction.c:11:
> include/linux/compaction.h:237:122: error: 'struct node' declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
> 
> The patch that likely introduced the problem added a forward declaration
> for 'struct node' in linux/compaction.h, but only in one of two instances.
> 
> This moves the declaration out of the #ifdef so we always get it.

http://ozlabs.org/~akpm/mmots/broken-out/mm-balloon-use-general-non-lru-movable-page-feature-fix.patch
should fix this.  I guess I should do another -mm.