linux-kernel - Re: [PATCH] zram: update zram to use zpool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 16 Jun 2016 08:17:32 +0900
From:	Minchan Kim <minchan@...nel.org>
To:	Geliang Tang <geliangtang@...il.com>
CC:	Nitin Gupta <ngupta@...are.org>,
	Sergey Senozhatsky <sergey.senozhatsky.work@...il.com>,
	Dan Streetman <ddstreet@...e.org>,
	Vitaly Wool <vitalywool@...il.com>,
	<linux-kernel@...r.kernel.org>, <linux-mm@...ck.org>
Subject: Re: [PATCH] zram: update zram to use zpool

On Wed, Jun 15, 2016 at 10:42:07PM +0800, Geliang Tang wrote:
> Change zram to use the zpool api instead of directly using zsmalloc.
> The zpool api doesn't have zs_compact() and zs_pool_stats() functions.
> I did the following two things to fix it.
> 1) I replace zs_compact() with zpool_shrink(), use zpool_shrink() to
>    call zs_compact() in zsmalloc.
> 2) The 'pages_compacted' attribute is showed in zram by calling
>    zs_pool_stats(). So in order not to call zs_pool_state() I move the
>    attribute to zsmalloc.
> 
> Signed-off-by: Geliang Tang <geliangtang@...il.com>

NACK.

I already explained why.
http://lkml.kernel.org/r/20160609013411.GA29779@bbox