linux-kernel - [patch] devlink: clean up a condition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 16 Jun 2016 09:50:32 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Or Gerlitz <ogerlitz@...lanox.com>
Cc:	Leon Romanovsky <leon@...nel.org>, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: [patch] devlink: clean up a condition

Presumably having a _get() function implies that we also have a _set()
function but lets make it match when we're calling.

Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

diff --git a/net/core/devlink.c b/net/core/devlink.c
index a4f88cb..b2e592a 100644
--- a/net/core/devlink.c
+++ b/net/core/devlink.c
@@ -1461,7 +1461,7 @@ static int devlink_nl_cmd_eswitch_mode_set_doit(struct sk_buff *skb,
 
 	mode = nla_get_u16(info->attrs[DEVLINK_ATTR_ESWITCH_MODE]);
 
-	if (ops && ops->eswitch_mode_get)
+	if (ops && ops->eswitch_mode_set)
 		return ops->eswitch_mode_set(devlink, mode);
 	return -EOPNOTSUPP;
 }